-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Channel type
icon on Engagement Dashboard
#26269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tassoevan
changed the title
[FIX] Update channel
Regression: Channel Jul 14, 2022
type
icon on engagement dashboardtype
icon on Engagement Dashboard
tassoevan
previously approved these changes
Jul 14, 2022
tassoevan
previously approved these changes
Jul 18, 2022
…engagement-dashboard
…ub.com/RocketChat/Rocket.chat into fix/channels-type-engagement-dashboard
tassoevan
approved these changes
Jul 19, 2022
casalsgh
added
stat: QA tested
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes a bug on which the channel type is inverted.
Issue(s)
Steps to test or reproduce
Further comments