Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add Offline License Endpoint #26282

Merged
merged 14 commits into from
Aug 18, 2022
Merged

[FIX] Add Offline License Endpoint #26282

merged 14 commits into from
Aug 18, 2022

Conversation

LucianoPierdona
Copy link
Contributor

Proposed changes (including videos or screenshots)

This PR updates the endpoint to add a license

Issue(s)

Steps to test or reproduce

Further comments

@LucianoPierdona LucianoPierdona requested a review from a team as a code owner July 15, 2022 19:50
@LucianoPierdona LucianoPierdona self-assigned this Jul 15, 2022
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you convert the file to TS? in that way we can prevent even more problems

@LucianoPierdona LucianoPierdona marked this pull request as draft July 15, 2022 20:04
@LucianoPierdona LucianoPierdona marked this pull request as ready for review July 15, 2022 21:08
@LucianoPierdona LucianoPierdona requested a review from a team as a code owner July 15, 2022 21:08
@LucianoPierdona LucianoPierdona requested a review from ggazzo July 15, 2022 21:10
@alvaropmello alvaropmello added this to the 5.0.1 milestone Jul 21, 2022
tassoevan
tassoevan previously approved these changes Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #26282 (b898b0a) into develop (563cc08) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26282      +/-   ##
===========================================
+ Coverage    38.66%   38.71%   +0.04%     
===========================================
  Files          759      758       -1     
  Lines        18809    18783      -26     
  Branches      1453     1453              
===========================================
- Hits          7273     7272       -1     
+ Misses       11320    11292      -28     
- Partials       216      219       +3     
Flag Coverage Δ
e2e 38.71% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@casalsgh casalsgh modified the milestones: 5.0.1, 5.0.2 Aug 1, 2022
ggazzo
ggazzo previously approved these changes Aug 1, 2022
@LucianoPierdona LucianoPierdona dismissed stale reviews from ggazzo and tassoevan via e0f9ce0 August 9, 2022 17:37
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 18, 2022
@alvaropmello alvaropmello added this to the 5.1.0 milestone Aug 18, 2022
@kodiakhq kodiakhq bot merged commit 06bf4ae into develop Aug 18, 2022
@kodiakhq kodiakhq bot deleted the fix/add-license-request branch August 18, 2022 23:19
csuadev pushed a commit that referenced this pull request Aug 26, 2022
Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com>
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants