-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Add Offline License Endpoint #26282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
requested changes
Jul 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you convert the file to TS? in that way we can prevent even more problems
…add-license-request
tassoevan
requested changes
Jul 28, 2022
tassoevan
previously approved these changes
Jul 28, 2022
Codecov Report
@@ Coverage Diff @@
## develop #26282 +/- ##
===========================================
+ Coverage 38.66% 38.71% +0.04%
===========================================
Files 759 758 -1
Lines 18809 18783 -26
Branches 1453 1453
===========================================
- Hits 7273 7272 -1
+ Misses 11320 11292 -28
- Partials 216 219 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
previously approved these changes
Aug 1, 2022
hugocostadev
approved these changes
Aug 18, 2022
ggazzo
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Aug 18, 2022
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR updates the endpoint to add a license
Issue(s)
Steps to test or reproduce
Further comments