-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] - Incoming SMSs no longer clash with ongoing livechat conversations by the same visitor #26307
Conversation
…ions by the same visitor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will a conversation coming from Widget or from an app collide with an already open room? 👀 if so, we can use this PR to discover that behavior to 🤗 and create a task for changing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better let's try that one outside here 👀
…o fix/sms-livechat-incoming-overlap
…RocketChat/Rocket.Chat into fix/sms-livechat-incoming-overlap
…o fix/sms-livechat-incoming-overlap
Codecov Report
@@ Coverage Diff @@
## develop #26307 +/- ##
===========================================
+ Coverage 38.54% 39.06% +0.52%
===========================================
Files 759 748 -11
Lines 18829 18647 -182
Branches 1459 1424 -35
===========================================
+ Hits 7258 7285 +27
+ Misses 11350 11140 -210
- Partials 221 222 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
…ions by the same visitor (#26307)
Proposed changes (including videos or screenshots)
There was a data race in the defineVisitor function, causing new guests to be created even if a registered guest with that number already existed, also made sure that the open room being searched on is the correct source type, so the clash is not possible anymore.
Issue(s)
Steps to test or reproduce
Further comments