Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] - Incoming SMSs no longer clash with ongoing livechat conversations by the same visitor #26307

Merged
merged 12 commits into from
Aug 12, 2022

Conversation

cauefcr
Copy link
Contributor

@cauefcr cauefcr commented Jul 19, 2022

Proposed changes (including videos or screenshots)

There was a data race in the defineVisitor function, causing new guests to be created even if a registered guest with that number already existed, also made sure that the open room being searched on is the correct source type, so the clash is not possible anymore.

Issue(s)

Steps to test or reproduce

Further comments

@cauefcr cauefcr requested a review from a team July 19, 2022 20:15
murtaza98
murtaza98 previously approved these changes Jul 20, 2022
Copy link
Contributor

@murtaza98 murtaza98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cauefcr cauefcr requested a review from KevLehman July 21, 2022 12:45
@alvaropmello alvaropmello added this to the 5.0.1 milestone Jul 21, 2022
Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will a conversation coming from Widget or from an app collide with an already open room? 👀 if so, we can use this PR to discover that behavior to 🤗 and create a task for changing it

Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better let's try that one outside here 👀

@casalsgh casalsgh modified the milestones: 5.0.1, 5.0.2 Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #26307 (8d454a7) into develop (50af9b2) will increase coverage by 0.52%.
The diff coverage is n/a.

❗ Current head 8d454a7 differs from pull request most recent head 38f0744. Consider uploading reports for the commit 38f0744 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26307      +/-   ##
===========================================
+ Coverage    38.54%   39.06%   +0.52%     
===========================================
  Files          759      748      -11     
  Lines        18829    18647     -182     
  Branches      1459     1424      -35     
===========================================
+ Hits          7258     7285      +27     
+ Misses       11350    11140     -210     
- Partials       221      222       +1     
Flag Coverage Δ
e2e 39.06% <ø> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 12, 2022
@kodiakhq kodiakhq bot merged commit 662ffb8 into develop Aug 12, 2022
@kodiakhq kodiakhq bot deleted the fix/sms-livechat-incoming-overlap branch August 12, 2022 19:34
@alvaropmello alvaropmello added this to the 5.1.0 milestone Aug 16, 2022
csuadev pushed a commit that referenced this pull request Aug 26, 2022
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants