-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] Added identification on calls to/from existing contacts #26334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove/call-contact-id
Codecov Report
@@ Coverage Diff @@
## develop #26334 +/- ##
===========================================
- Coverage 38.67% 38.62% -0.05%
===========================================
Files 792 793 +1
Lines 18894 18900 +6
Branches 1937 1939 +2
===========================================
- Hits 7307 7301 -6
- Misses 11297 11309 +12
Partials 290 290
Flags with carried forward coverage won't be shown. Click here to find out more. |
tiagoevanp
requested changes
Aug 3, 2022
…ove/call-contact-id
…ove/call-contact-id
…ove/call-contact-id
…t.Chat into improve/call-contact-id
ggazzo
force-pushed
the
improve/call-contact-id
branch
2 times, most recently
from
August 25, 2022 03:51
ee4484f
to
52dba05
Compare
ggazzo
requested changes
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can ask you to check the two TODO: that I'd inserted? thanks
ggazzo
force-pushed
the
improve/call-contact-id
branch
from
August 25, 2022 04:03
52dba05
to
b3481ae
Compare
ggazzo
previously approved these changes
Aug 25, 2022
tiagoevanp
previously approved these changes
Aug 25, 2022
aleksandernsilva
dismissed stale reviews from tiagoevanp and ggazzo
via
August 25, 2022 14:33
bbf2889
tiagoevanp
previously approved these changes
Aug 25, 2022
ggazzo
approved these changes
Aug 25, 2022
ggazzo
requested changes
Aug 25, 2022
tiagoevanp
approved these changes
Aug 25, 2022
ggazzo
approved these changes
Aug 25, 2022
gabriellsh
added a commit
that referenced
this pull request
Aug 26, 2022
…hreads * 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits) Chore: Upgrade dependencies (#26694) Chore: More Omnichannel tests (#26691) Regression: Banner - Room not found - Omnichannel room (#26693) [NEW] Capability to search visitors by custom fields (#26312) Chore: Create tests for Omnichannel admin add a custom fields (#26609) [FIX] Avatars of other chats disappear when they located near chat with broken avatar (#26689) [IMPROVE] Added identification on calls to/from existing contacts (#26334) Regression: invalid statistics format (#26684) Regression: "Cache size is not a function" error when booting (#26683) [FIX] Correct IMAP configuration for email inbox (#25789) [FIX] Active users count on `@all` and `@here` (#25957) [FIX] Autotranslate method should respect setting (#26549) Chore: Remove italic/bold font-style from system messages (#26655) Chore: Convert AppSetting to tsx (#26625) Chore: Remove & Test old closeChat templates (#26631) [IMPROVE] General federation improvements (#26150) [NEW] Warn admins about running multiple instances of the monolith (#26667) Regression: Prevent message from being temp forever (#26668) Regression: Add alsoSendThreadToChannel to user settings api (#26663) [IMPROVE] Spotlight search user results (#26599) ...
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
…6334) Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com> Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Before:
After:
Issue(s)
Steps to test or reproduce
Further comments