Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Prune messages not removing thumbnails #26443

Merged
merged 9 commits into from
Aug 17, 2022

Conversation

LucianoPierdona
Copy link
Contributor

@LucianoPierdona LucianoPierdona commented Aug 2, 2022

Proposed changes (including videos or screenshots)

This PR adds a method on Uploads called findOneByName, and excludes a thumbnail of an image on cleanRoomHistory

Issue(s)

Fix #26287

Steps to test or reproduce

  • Go to Prune Messages
  • Click on Prune. After Prune completed successfully
  • Go and click on Files
  • All tumbnail files are still there

Further comments

@LucianoPierdona LucianoPierdona marked this pull request as ready for review August 3, 2022 17:56
@LucianoPierdona LucianoPierdona requested a review from a team as a code owner August 3, 2022 17:56
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #26443 (9f35134) into develop (b3bc896) will increase coverage by 0.22%.
The diff coverage is n/a.

❗ Current head 9f35134 differs from pull request most recent head cfbb93e. Consider uploading reports for the commit cfbb93e to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26443      +/-   ##
===========================================
+ Coverage    38.47%   38.70%   +0.22%     
===========================================
  Files          758      758              
  Lines        18823    18818       -5     
  Branches      1453     1461       +8     
===========================================
+ Hits          7243     7284      +41     
+ Misses       11363    11315      -48     
- Partials       217      219       +2     
Flag Coverage Δ
e2e 38.70% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 15, 2022
@alvaropmello alvaropmello added this to the 5.1.0 milestone Aug 16, 2022
@kodiakhq kodiakhq bot merged commit f28db32 into develop Aug 17, 2022
@kodiakhq kodiakhq bot deleted the fix/prune-messages-not-deleting-thumbnails branch August 17, 2022 01:05
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
@alekdimitrov
Copy link

alekdimitrov commented Nov 20, 2022

Hi. Im sorry but I want open this issue again. I am on 5.2.3 version and issue is still not fixed.
Thanks.

p.p. 5.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: team-collab stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prune Messages doesn't delete thumbnail files
7 participants