[IMPROVE] New 'not found page' design #26452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guijun13
changed the title
guijun13
changed the title
|
Since there is a discrepancy of React dependencies in the mocha.js and in the @rocket.chat/ui-contexts hooks, the existing tests (apps/meteor/tests/unit/client/views/notFound/NotFoundPage.spec.tsx) were not changed, just removed some unnecessary test cases. |
gabriellsh
previously approved these changes
Aug 8, 2022
…/not-found-page * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Remove settings Fibers usage (#26465) Chore: Refactor create-target-channel util (#26493) Chore: useEndpointData deprecation (#26494) [NEW] Surface featured apps endpoint (#26416) [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490) Chore: Exit process on `unhandledRejection` on CI (#26467) [FIX] Clear push token on save user password (#26466) [FIX] Undefined MediaDevices error on HTTP (#26396) Chore: Codecov threshold (#26477)
gabriellsh
previously approved these changes
Aug 8, 2022
gabriellsh
previously approved these changes
Aug 9, 2022
ggazzo
added
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #26452 +/- ##
===========================================
+ Coverage 38.60% 38.68% +0.07%
===========================================
Files 758 758
Lines 18783 18783
Branches 1453 1453
===========================================
+ Hits 7252 7267 +15
+ Misses 11315 11298 -17
- Partials 216 218 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
previously approved these changes
Aug 15, 2022
…ocket.Chat into feat/not-found-page
gabriellsh
approved these changes
Aug 18, 2022
dougfabris
approved these changes
Aug 18, 2022
ggazzo
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments