Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Save edited tags for omnichannel departments #26481

Merged
merged 22 commits into from
Aug 18, 2022

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Aug 4, 2022

Proposed changes (including videos or screenshots)

A simple workaround for the main problem, when editing a department must be possible to save addition or remotion of tags.

Issue(s)

Steps to test or reproduce

Further comments

@tiagoevanp tiagoevanp marked this pull request as ready for review August 4, 2022 21:14
@tiagoevanp tiagoevanp requested a review from a team as a code owner August 4, 2022 21:14
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #26481 (97b81be) into develop (fe26bce) will increase coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 97b81be differs from pull request most recent head 05f9397. Consider uploading reports for the commit 05f9397 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26481      +/-   ##
===========================================
+ Coverage    38.54%   38.70%   +0.16%     
===========================================
  Files          758      758              
  Lines        18827    18829       +2     
  Branches      1453     1453              
===========================================
+ Hits          7256     7288      +32     
+ Misses       11355    11325      -30     
  Partials       216      216              
Flag Coverage Δ
e2e 38.70% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think comparing the old x new value would be the best solution

btw dont forget e2e tests!

@tiagoevanp tiagoevanp requested a review from a team as a code owner August 11, 2022 21:22
KevLehman
KevLehman previously approved these changes Aug 15, 2022
Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function-wise seems to be working 👀

@alvaropmello alvaropmello added this to the 5.1.0 milestone Aug 16, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 17, 2022
…t.js

Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
@kodiakhq kodiakhq bot merged commit 6cc17f1 into develop Aug 18, 2022
@kodiakhq kodiakhq bot deleted the fix/edit-department-tag branch August 18, 2022 00:33
csuadev pushed a commit that referenced this pull request Aug 26, 2022
Co-authored-by: Aleksander Nicacio da Silva <6494543+aleksandernsilva@users.noreply.github.com>
Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants