Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] VideoConference Messages UI #26548

Merged
merged 36 commits into from
Sep 22, 2022
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 11, 2022

Proposed changes (including videos or screenshots)

Task: VC-2

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #26548 (aaa8951) into develop (21405eb) will increase coverage by 0.17%.
The diff coverage is 0.00%.

❗ Current head aaa8951 differs from pull request most recent head 2b7997b. Consider uploading reports for the commit 2b7997b to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26548      +/-   ##
===========================================
+ Coverage    40.80%   40.98%   +0.17%     
===========================================
  Files          792      791       -1     
  Lines        17814    17822       +8     
  Branches      1929     1928       -1     
===========================================
+ Hits          7269     7304      +35     
+ Misses       10253    10220      -33     
- Partials       292      298       +6     
Flag Coverage Δ
e2e 40.98% <0.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris requested a review from a team as a code owner August 18, 2022 13:35
@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2022

This pull request introduces 3 alerts when merging 8a2d435 into 6cc17f1 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@ggazzo ggazzo requested a review from a team as a code owner August 22, 2022 19:00
@lgtm-com
Copy link

lgtm-com bot commented Aug 22, 2022

This pull request introduces 4 alerts when merging 5de626c into 8a2899f - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2022

This pull request introduces 1 alert when merging c17c1c9 into 655a6fd - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2022

This pull request introduces 1 alert when merging dfbcdb8 into d326414 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2022

This pull request introduces 1 alert when merging 0a3f457 into 76ed463 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2022

This pull request introduces 1 alert when merging b4e237d into 76ed463 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2022

This pull request introduces 1 alert when merging ec6d254 into 76ed463 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@pierre-lehnen-rc pierre-lehnen-rc force-pushed the improve/videoconf-messages branch from 3386f8f to a2a8ea5 Compare September 1, 2022 16:52
@alvaropmello alvaropmello added this to the 5.2.0 milestone Sep 13, 2022
ggazzo
ggazzo previously approved these changes Sep 16, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Sep 22, 2022
@ggazzo ggazzo merged commit 5ed3271 into develop Sep 22, 2022
@ggazzo ggazzo deleted the improve/videoconf-messages branch September 22, 2022 17:46
pierre-lehnen-rc added a commit that referenced this pull request Sep 27, 2022
sampaiodiego pushed a commit that referenced this pull request Sep 29, 2022
@pierre-lehnen-rc pierre-lehnen-rc restored the improve/videoconf-messages branch September 29, 2022 19:07
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
@dougfabris dougfabris deleted the improve/videoconf-messages branch April 25, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: video conferencing stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants