Regression: Update custom homepage content behavior #26571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26571 +/- ##
===========================================
+ Coverage 38.54% 38.67% +0.13%
===========================================
Files 758 759 +1
Lines 18827 18832 +5
Branches 1453 1453
===========================================
+ Hits 7256 7284 +28
+ Misses 11355 11330 -25
- Partials 216 218 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
hugocostadev
previously approved these changes
Aug 16, 2022
sampaiodiego
requested changes
Aug 16, 2022
sampaiodiego
previously approved these changes
Aug 16, 2022
tassoevan
previously approved these changes
Aug 17, 2022
|
is this a chore? or more like a regression? changing the name just in case |
ggazzo
changed the title
ggazzo
added
stat: ready to merge
kodiakhq
bot
removed
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
…ove/home * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Wait subscription to expose message composer (#26600)
gabriellsh
dismissed stale reviews from tassoevan, sampaiodiego, and hugocostadev
via
9137e58
hugocostadev
previously approved these changes
Aug 17, 2022
hugocostadev
approved these changes
Aug 17, 2022
ggazzo
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Custom homepage content should now be always visible below the default cards (in case there is any content there).
For enterprise, a new setting was created
Show custom content only, which when enabled should hide the default cards.Issue(s)
Steps to test or reproduce
Further comments