Chore: Fail-fast on callbacks #26572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26572 +/- ##
===========================================
+ Coverage 38.57% 38.67% +0.10%
===========================================
Files 758 758
Lines 18783 18783
Branches 1453 1453
===========================================
+ Hits 7246 7265 +19
+ Misses 11322 11300 -22
- Partials 215 218 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
murtaza98
reviewed
Aug 16, 2022
apps/meteor/ee/app/livechat-enterprise/server/hooks/handleNextAgentPreferredEvents.js
Outdated
Show resolved
Hide resolved
murtaza98
previously approved these changes
Aug 17, 2022
|
@sampaiodiego , from our side, no changes would change "functionality", so we should be good skipping QA for this one after you review it 👀 |
sampaiodiego
requested changes
Aug 17, 2022
…ket.Chat into chore/callbacks-fail-fast
sampaiodiego
requested changes
Aug 19, 2022
| @@ -30,7 +30,6 @@ export class Subscriptions extends Base { | |||
| this.tryEnsureIndex({ emailNotifications: 1 }, { sparse: 1 }); | |||
| this.tryEnsureIndex({ autoTranslate: 1 }, { sparse: 1 }); | |||
| this.tryEnsureIndex({ autoTranslateLanguage: 1 }, { sparse: 1 }); | |||
| this.tryEnsureIndex({ 'userHighlights.0': 1 }, { sparse: 1 }); | |||
There was a problem hiding this comment.
Wait, i removed that one lol. Thanks for fixing it.
sampaiodiego
approved these changes
Aug 19, 2022
ggazzo
added
stat: ready to merge
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
Co-authored-by: murtaza98 <murtaza.patrawala@rocket.chat>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
The idea of this PR is to skip some omnichannel-only callbacks when the room/message being passed is not from Omnichannel. This will allow other messages to perform a little bit better.