Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Convert AppSettingsAssembler to tsx #26626

Merged
merged 5 commits into from
Aug 22, 2022

Conversation

juliajforesti
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@juliajforesti juliajforesti requested a review from a team August 19, 2022 14:16
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #26626 (9c786ea) into develop (6e3306b) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 9c786ea differs from pull request most recent head fec7a6f. Consider uploading reports for the commit fec7a6f to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26626      +/-   ##
===========================================
+ Coverage    38.71%   38.73%   +0.01%     
===========================================
  Files          751      758       +7     
  Lines        18670    18783     +113     
  Branches      1453     1453              
===========================================
+ Hits          7228     7275      +47     
- Misses       11225    11290      +65     
- Partials       217      218       +1     
Flag Coverage Δ
e2e 38.73% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review August 19, 2022 20:10
@ggazzo ggazzo requested a review from a team as a code owner August 19, 2022 20:10
@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 22, 2022
@kodiakhq kodiakhq bot merged commit 00e1b2c into develop Aug 22, 2022
@kodiakhq kodiakhq bot deleted the chore/convert-AppSettingsAssembler branch August 22, 2022 14:16
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng day stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants