Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Use a single notification listener for all videoconf messages #26682

Merged
merged 6 commits into from
Oct 17, 2022
Merged

Chore: Use a single notification listener for all videoconf messages #26682

merged 6 commits into from
Oct 17, 2022

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Aug 25, 2022 •
edited by jira bot
Loading

Proposed changes (including videos or screenshots)

Task: VC-1

Issue(s)

Steps to test or reproduce

Further comments

@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner August 25, 2022 15:09
@codecov
Copy link

codecov bot commented Aug 25, 2022 •
edited
Loading

Codecov Report

Merging #26682 (d457654) into develop (ded6352) will increase coverage by 0.76%.
The diff coverage is 4.34%.

❗ Current head d457654 differs from pull request most recent head d53c864. Consider uploading reports for the commit d53c864 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26682      +/-   ##
===========================================
+ Coverage    40.22%   40.98%   +0.76%     
===========================================
  Files          827      802      -25     
  Lines        18241    17819     -422     
  Branches      2020     1972      -48     
===========================================
- Hits          7337     7303      -34     
+ Misses       10609    10223     -386     
+ Partials       295      293       -2
Flag Coverage Δ
e2e 40.98% <4.34%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego changed the title [IMPROVE] Use a single notification listener for all videoconf messages. Chore: Use a single notification listener for all videoconf messages Sep 19, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 19, 2022
@pierre-lehnen-rc pierre-lehnen-rc added this to the 5.3.0 milestone Oct 14, 2022
@kodiakhq kodiakhq bot merged commit c8f61e5 into develop Oct 17, 2022
@kodiakhq kodiakhq bot deleted the improve/videoconf/single-notifications branch October 17, 2022 20:45
MartinSchoeler pushed a commit that referenced this pull request Oct 25, 2022
@pierre-lehnen-rc @sampaiodiego @MartinSchoeler
Chore: Use a single notification listener for all videoconf messages (#…
f01b42d 
…26682)

Co-authored-by: Diego Sampaio <8591547+sampaiodiego@users.noreply.github.com>
@ggazzo ggazzo mentioned this pull request Nov 1, 2022
Merged
MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022
@pierre-lehnen-rc @sampaiodiego @MartinSchoeler
Chore: Use a single notification listener for all videoconf messages (#…
1fdebfa 
…26682)

Co-authored-by: Diego Sampaio <8591547+sampaiodiego@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris approved these changes

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pierre-lehnen-rc @sampaiodiego @dougfabris @ggazzo