[FIX] Business Units endpoints not filtering by Unit type #26713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
murtaza98
reviewed
Aug 29, 2022
apps/meteor/app/livechat/server/roomAccessValidator.compatibility.js
Outdated
Show resolved
Hide resolved
murtaza98
previously approved these changes
Aug 29, 2022
murtaza98
reviewed
Aug 29, 2022
…ess units they are monitoring.
murtaza98
reviewed
Aug 29, 2022
Codecov Report
@@ Coverage Diff @@
## develop #26713 +/- ##
===========================================
- Coverage 40.61% 40.59% -0.02%
===========================================
Files 799 799
Lines 18306 18306
Branches 1957 1957
===========================================
- Hits 7435 7432 -3
- Misses 10576 10580 +4
+ Partials 295 294 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
murtaza98
approved these changes
Aug 29, 2022
ggazzo
added
stat: ready to merge
KevLehman
changed the title
sampaiodiego
deleted the
regression/business-units-not-working-properly
branch
sampaiodiego
pushed a commit
that referenced
this pull request
Aug 29, 2022
Co-authored-by: murtaza98 <murtaza.patrawala@rocket.chat>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Clickup: https://app.clickup.com/t/2rbzqeq