Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Workaround to handle auto stopped computations 😞 #26745

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 30, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo marked this pull request as ready for review August 30, 2022 18:38
@ggazzo ggazzo requested a review from a team as a code owner August 30, 2022 18:38
@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #26745 (5132ea3) into develop (0790192) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26745      +/-   ##
===========================================
+ Coverage    40.39%   40.65%   +0.25%     
===========================================
  Files          802      799       -3     
  Lines        18446    18309     -137     
  Branches      1956     1957       +1     
===========================================
- Hits          7451     7443       -8     
+ Misses       10702    10570     -132     
- Partials       293      296       +3     
Flag Coverage Δ
e2e 40.65% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 473455a into develop Aug 30, 2022
@ggazzo ggazzo deleted the regression/useReactiveValue branch August 30, 2022 18:50
gabriellsh added a commit that referenced this pull request Sep 1, 2022
* origin/develop:
  Chore: Fix docker latest tag push (#26770)
  Regression: Custom fields not being saved for room (#26747)
  Regression: Fix Current Chats Page Issues (#26744)
  Regression: Empty custom-fields filter on Current Chats causing issues (#26720)
  Regression: Sidebar Search list local data cache and keyboard navigation (#26764)
  Regression: Select settings options not visible on Apps Setting panel (#26759)
  Regression: AutoTranslate is disabled error (#26701)
  Regression: REST setUserPublicAndPrivateKeys (#26753)
  Regression: Workaround to handle auto stopped computations 😞 (#26745)
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants