-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Scrollable report message #26853
Merged
kodiakhq
merged 8 commits into
RocketChat:develop
from
yasemincidem:fix/scrollable-report-message-modal
Nov 22, 2022
Merged
[FIX] Scrollable report message #26853
kodiakhq
merged 8 commits into
RocketChat:develop
from
yasemincidem:fix/scrollable-report-message-modal
Nov 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougfabris
requested changes
Sep 27, 2022
apps/meteor/client/views/room/modals/ReportMessageModal/ReportMessageModal.tsx
Outdated
Show resolved
Hide resolved
dougfabris
requested changes
Sep 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you missed the margin prop 😅
apps/meteor/client/views/room/modals/ReportMessageModal/ReportMessageModal.tsx
Outdated
Show resolved
Hide resolved
oops. That is right :) |
dougfabris
approved these changes
Sep 28, 2022
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Nov 22, 2022
Codecov Report
@@ Coverage Diff @@
## develop #26853 +/- ##
========================================
Coverage 41.96% 41.96%
========================================
Files 813 813
Lines 17840 17840
Branches 1989 1989
========================================
+ Hits 7486 7487 +1
- Misses 10063 10066 +3
+ Partials 291 287 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The ellipsis is used to specify that some text has overflown in report message modal instead of scrolling all the content inside the modal.
Issue(s)
Fixes: #26837
Steps to test or reproduce
Further comments