Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Scrollable report message #26853

Merged

Conversation

yasemincidem
Copy link
Contributor

Proposed changes (including videos or screenshots)

The ellipsis is used to specify that some text has overflown in report message modal instead of scrolling all the content inside the modal.

Screen Shot 2022-09-12 at 10 46 43 PM

Issue(s)

Fixes: #26837

Steps to test or reproduce

Further comments

@yasemincidem yasemincidem requested a review from a team as a code owner September 12, 2022 20:25
@CLAassistant
Copy link

CLAassistant commented Sep 12, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you missed the margin prop 😅

@dougfabris dougfabris added this to the 5.3.0 milestone Sep 28, 2022
@yasemincidem
Copy link
Contributor Author

you missed the margin prop 😅

oops. That is right :)

@yasemincidem yasemincidem reopened this Sep 29, 2022
@d-gubert d-gubert modified the milestones: 5.3.0, 5.4.0 Oct 19, 2022
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #26853 (039fa5f) into develop (8706c3f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #26853   +/-   ##
========================================
  Coverage    41.96%   41.96%           
========================================
  Files          813      813           
  Lines        17840    17840           
  Branches      1989     1989           
========================================
+ Hits          7486     7487    +1     
- Misses       10063    10066    +3     
+ Partials       291      287    -4     
Flag Coverage Δ
e2e 41.96% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit b816803 into RocketChat:develop Nov 22, 2022
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
communityPR stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal scroll is enabled in "report this message modal" layout
7 participants