Chore: Refactor AppLogs to TS #26938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrote the AppLogs component to TS. Also, improved some error handling logic.
Codecov Report
@@ Coverage Diff @@
## develop #26938 +/- ##
===========================================
- Coverage 40.19% 40.15% -0.04%
===========================================
Files 827 827
Lines 18258 18241 -17
Branches 2020 2020
===========================================
- Hits 7339 7325 -14
+ Misses 10626 10617 -9
- Partials 293 299 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
Refactored the AppLogs component so that it has proper endpoint typing and stopped using unnecessary logic to show the logs.
ggazzo
added
stat: ready to merge
dougfabris
requested changes
Oct 4, 2022
dougfabris
requested changes
Oct 5, 2022
Co-authored-by: Douglas Fabris <devfabris@gmail.com>
juliajforesti
approved these changes
Oct 5, 2022
dougfabris
approved these changes
Oct 5, 2022
dougfabris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Rewrote the AppLogs component to TS. Also, improved some error handling logic.
Issue(s)
Steps to test or reproduce
Further comments