Regression: Sidebar Room List not working properly. #26950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
approved these changes
Sep 26, 2022
Codecov Report
@@ Coverage Diff @@
## develop #26950 +/- ##
===========================================
+ Coverage 40.78% 40.97% +0.18%
===========================================
Files 801 801
Lines 17920 17920
Branches 1960 1960
===========================================
+ Hits 7309 7342 +33
+ Misses 10313 10281 -32
+ Partials 298 297 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
added
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The CachedCollection Class was assuming that the passed parameter would be modified, instead of using the callback return.
Issue(s)
Steps to test or reproduce
Further comments