Chore: deprecate refreshClients methods #26956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26956 +/- ##
===========================================
+ Coverage 40.48% 42.02% +1.53%
===========================================
Files 840 814 -26
Lines 18329 17841 -488
Branches 2052 1988 -64
===========================================
+ Hits 7421 7498 +77
+ Misses 10622 10055 -567
- Partials 286 288 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
previously approved these changes
Sep 28, 2022
sampaiodiego
previously requested changes
Oct 18, 2022
There was a problem hiding this comment.
@ggazzo should we remove this functionality completely? the button "apply and refresh clients" doesn't work at all.. no reason to keep it there.
ggazzo
reviewed
Nov 21, 2022
ggazzo
reviewed
Nov 21, 2022
ggazzo
reviewed
Nov 21, 2022
apps/meteor/client/views/admin/settings/groups/AssetsGroupPage.tsx
Outdated
Show resolved
Hide resolved
ggazzo
reviewed
Nov 21, 2022
ggazzo
reviewed
Nov 21, 2022
ggazzo
approved these changes
Nov 21, 2022
dionisio-bot
bot
added
stat: ready to merge
ggazzo
changed the title
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Created the 'assets.refreshClients' endpoint for the
apps/meteor/client/views/admin/settings/groups/AssetsGroupPage.tsxfile.Issue(s)
Steps to test or reproduce
Further comments