Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Remove symbols from number before storing PBX event #26969

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Sep 28, 2022

  • Also update query to support numbers already stored with * or + signs due to client refactor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

OC-256

@KevLehman KevLehman requested a review from a team as a code owner September 28, 2022 16:04
@KevLehman KevLehman added this to the 5.2.0 milestone Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #26969 (9d0522d) into develop (4ecf45b) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26969      +/-   ##
===========================================
- Coverage    41.00%   40.96%   -0.04%     
===========================================
  Files          801      801              
  Lines        17907    17907              
  Branches      1960     1960              
===========================================
- Hits          7342     7335       -7     
- Misses       10270    10273       +3     
- Partials       295      299       +4     
Flag Coverage Δ
e2e 40.96% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 29, 2022
@tassoevan tassoevan changed the title Regression: Remove symbols from number b4 storing pbx event Regression: Remove symbols from number before storing PBX event Sep 29, 2022
@tassoevan tassoevan merged commit 4f27e21 into develop Sep 29, 2022
@tassoevan tassoevan deleted the regression/symbols-on-pbx-event-number branch September 29, 2022 21:33
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants