Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Fixed takeInquiry method not displaying error messages on the client #26976

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

aleksandernsilva
Copy link
Contributor

Proposed changes (including videos or screenshots)

This pull request brings back the toast message "The maximum number of simultaneous chats per agent has been reached." that should be displayed when an agent tries to take more chats than the maximum allowed.

image

Issue(s)

Steps to test or reproduce

Further comments

OC-267

@aleksandernsilva aleksandernsilva self-assigned this Sep 28, 2022
@aleksandernsilva aleksandernsilva changed the title [FIX] Fixed takeInquiry method not displaying error messages on the client Regression: Fixed takeInquiry method not displaying error messages on the client Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #26976 (79448e4) into develop (0e6bc45) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26976      +/-   ##
===========================================
- Coverage    40.39%   40.18%   -0.22%     
===========================================
  Files          826      826              
  Lines        18361    18361              
  Branches      2020     2020              
===========================================
- Hits          7417     7378      -39     
- Misses       10645    10686      +41     
+ Partials       299      297       -2     
Flag Coverage Δ
e2e 40.18% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review September 29, 2022 12:46
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner September 29, 2022 12:46
MartinSchoeler
MartinSchoeler previously approved these changes Sep 29, 2022
@MartinSchoeler MartinSchoeler added this to the 5.2.0 milestone Sep 29, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Oct 3, 2022
@ggazzo ggazzo merged commit 67d5339 into develop Oct 4, 2022
@ggazzo ggazzo deleted the regression/livechat-takeInquiry-client-error branch October 4, 2022 04:54
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants