Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Use cached EE Cloud license on startup #26987

Merged
merged 14 commits into from
Oct 4, 2022

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Sep 30, 2022

Proposed changes (including videos or screenshots)

  • Few changes to error logs when an error happens with requests to Cloud:
    • Make sure to always show a meaningful log
    • Add a new property to logs called cloudError with the returned error from the API
    • Add a new property url containing the URL called
  • The call to getWorkspaceLicense was moved to a finally to make sure it is always called
  • getWorkspaceLicense now uses the license saved on DB if the request to get a new one fails

Issue(s)

ARCH-54

Steps to test or reproduce

Further comments

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 30, 2022
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #26987 (a2d5714) into develop (67d5339) will increase coverage by 0.57%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26987      +/-   ##
===========================================
+ Coverage    40.11%   40.68%   +0.57%     
===========================================
  Files          829      804      -25     
  Lines        18376    17923     -453     
  Branches      2019     1960      -59     
===========================================
- Hits          7371     7292      -79     
+ Misses       10708    10328     -380     
- Partials       297      303       +6     
Flag Coverage Δ
e2e 40.68% <ø> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego marked this pull request as ready for review October 3, 2022 12:51
@sampaiodiego sampaiodiego requested review from a team as code owners October 3, 2022 12:51
@sampaiodiego sampaiodiego force-pushed the improve-cloud-error-messages branch from de02a75 to 6d6a3de Compare October 3, 2022 20:04
@sampaiodiego sampaiodiego changed the title Chore: Improve Cloud error messages Chore: Use cached Cloud license on startup Oct 3, 2022
@sampaiodiego sampaiodiego added this to the 5.2.0 milestone Oct 4, 2022
@sampaiodiego sampaiodiego changed the title Chore: Use cached Cloud license on startup [IMPROVE] Use cached EE Cloud license on startup Oct 4, 2022
@sampaiodiego sampaiodiego merged commit 0c1ab59 into develop Oct 4, 2022
@sampaiodiego sampaiodiego deleted the improve-cloud-error-messages branch October 4, 2022 13:12
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants