-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] Use cached EE Cloud license on startup #26987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Sep 30, 2022
Codecov Report
@@ Coverage Diff @@
## develop #26987 +/- ##
===========================================
+ Coverage 40.11% 40.68% +0.57%
===========================================
Files 829 804 -25
Lines 18376 17923 -453
Branches 2019 1960 -59
===========================================
- Hits 7371 7292 -79
+ Misses 10708 10328 -380
- Partials 297 303 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
force-pushed
the
improve-cloud-error-messages
branch
from
October 3, 2022 20:04
de02a75
to
6d6a3de
Compare
This reverts commit da371c1.
sampaiodiego
changed the title
Chore: Improve Cloud error messages
Chore: Use cached Cloud license on startup
Oct 3, 2022
sampaiodiego
changed the title
Chore: Use cached Cloud license on startup
[IMPROVE] Use cached EE Cloud license on startup
Oct 4, 2022
ggazzo
approved these changes
Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
cloudError
with the returned error from the APIurl
containing the URL calledgetWorkspaceLicense
was moved to afinally
to make sure it is always calledgetWorkspaceLicense
now uses the license saved on DB if the request to get a new one failsIssue(s)
ARCH-54
Steps to test or reproduce
Further comments