Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove default value from custom home content setting #26995

Merged
merged 6 commits into from
Oct 15, 2022

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Oct 3, 2022

Proposed changes (including videos or screenshots)

Remove content from Custom body setting so that new workspaces don't have initial unstyled HTML in their homepages.

Issue(s)

TC-145

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #26995 (057e117) into develop (1866dfc) will decrease coverage by 0.37%.
The diff coverage is n/a.

❗ Current head 057e117 differs from pull request most recent head c2e02c2. Consider uploading reports for the commit c2e02c2 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26995      +/-   ##
===========================================
- Coverage    40.31%   39.93%   -0.38%     
===========================================
  Files          827      827              
  Lines        18258    18263       +5     
  Branches      2020     2020              
===========================================
- Hits          7360     7294      -66     
- Misses       10604    10673      +69     
- Partials       294      296       +2     
Flag Coverage Δ
e2e 39.93% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabriellsh gabriellsh requested a review from a team as a code owner October 6, 2022 02:28
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Oct 11, 2022
@gabriellsh gabriellsh added this to the 5.3.0 milestone Oct 14, 2022
@kodiakhq kodiakhq bot merged commit 9956a84 into develop Oct 15, 2022
@kodiakhq kodiakhq bot deleted the removeDefaultCustomContent branch October 15, 2022 00:01
@ggazzo ggazzo mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants