-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Implement short description for marketplace apps #27030
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented the shortDescription field in the marketplace app details header. Now apps have either a shorter description or nothing in their headers description section.
Codecov Report
@@ Coverage Diff @@
## develop #27030 +/- ##
===========================================
+ Coverage 39.91% 41.03% +1.12%
===========================================
Files 827 802 -25
Lines 18263 17810 -453
Branches 2020 1961 -59
===========================================
+ Hits 7290 7309 +19
+ Misses 10678 10204 -474
- Partials 295 297 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Oct 10, 2022
juliajforesti
approved these changes
Oct 11, 2022
dougfabris
approved these changes
Oct 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Jira task: MKP-126
Implemented the shortDescription field in the marketplace app details header. Now apps have either a shorter description or nothing, in case it doesn't have a shortDescription registered, in their headers description section.
Demo image:
Issue(s)
Steps to test or reproduce
Further comments