Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Implement short description for marketplace apps #27030

Merged
merged 8 commits into from
Oct 14, 2022

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Oct 7, 2022

Proposed changes (including videos or screenshots)

Jira task: MKP-126

Implemented the shortDescription field in the marketplace app details header. Now apps have either a shorter description or nothing, in case it doesn't have a shortDescription registered, in their headers description section.
Demo image:
image

Issue(s)

Steps to test or reproduce

Further comments

Implemented the shortDescription field in the marketplace app details header. Now apps have either a shorter description or nothing in their headers description section.
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #27030 (bc9350c) into develop (31ee000) will increase coverage by 1.12%.
The diff coverage is n/a.

❗ Current head bc9350c differs from pull request most recent head 6228057. Consider uploading reports for the commit 6228057 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27030      +/-   ##
===========================================
+ Coverage    39.91%   41.03%   +1.12%     
===========================================
  Files          827      802      -25     
  Lines        18263    17810     -453     
  Branches      2020     1961      -59     
===========================================
+ Hits          7290     7309      +19     
+ Misses       10678    10204     -474     
- Partials       295      297       +2     
Flag Coverage Δ
e2e 41.03% <ø> (+1.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 10, 2022
@rique223 rique223 marked this pull request as ready for review October 11, 2022 19:06
@rique223 rique223 requested review from a team as code owners October 11, 2022 19:06
@rique223 rique223 added this to the 5.3.0 milestone Oct 11, 2022
@kodiakhq kodiakhq bot merged commit f4f8cd1 into develop Oct 14, 2022
@kodiakhq kodiakhq bot deleted the chore/implement-short-description branch October 14, 2022 15:30
@ggazzo ggazzo mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants