Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Add new endpoint 'livechat/agent.status' & deprecate changeLivechatStatus meteor method #27047

Merged
merged 20 commits into from
Nov 7, 2022
Merged

[NEW] Add new endpoint 'livechat/agent.status' & deprecate changeLivechatStatus meteor method #27047

merged 20 commits into from
Nov 7, 2022

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Oct 11, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

Issue(s)

Jira: OC-355

Steps to test or reproduce

Further comments

@murtaza98 murtaza98 requested review from a team as code owners October 11, 2022 11:09
@codecov
Copy link

codecov bot commented Oct 11, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@1a4d9ba). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #27047   +/-   ##
==========================================
  Coverage           ?   40.92%           
==========================================
  Files              ?      851           
  Lines              ?    18679           
  Branches           ?     2049           
==========================================
  Hits               ?     7644           
  Misses             ?    10751           
  Partials           ?      284
Flag Coverage Δ
e2e 40.92% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

KevLehman
KevLehman previously requested changes Oct 11, 2022
View reviewed changes
apps/meteor/tests/data/livechat/businessHours.ts Show resolved Hide resolved
apps/meteor/app/livechat/server/api/v1/agent.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/api/v1/agent.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/api/v1/agent.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/api/v1/agent.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/api/v1/agent.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/api/v1/agent.ts Show resolved Hide resolved
apps/meteor/tests/end-to-end/api/livechat/01-agents.ts Outdated Show resolved Hide resolved
apps/meteor/tests/end-to-end/api/livechat/methods/changeLivechatStatus.ts Outdated Show resolved Hide resolved
packages/core-typings/src/IUser.ts Outdated Show resolved Hide resolved
@murtaza98 murtaza98 requested a review from KevLehman October 13, 2022 10:58
@murtaza98 murtaza98 dismissed KevLehman’s stale review October 13, 2022 10:59

Changes done :)

cauefcr
cauefcr previously approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@cauefcr cauefcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the code manually, rand the e2e api tests, read every change, the concerns kevin brought up were addressed, approving the PR.

MartinSchoeler
MartinSchoeler previously approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the very minor change I've requested, everything seems to be working on FE

apps/meteor/client/sidebar/sections/OmnichannelSection.tsx Outdated Show resolved Hide resolved
KevLehman
KevLehman previously approved these changes Oct 15, 2022
View reviewed changes
@murtaza98 murtaza98 dismissed stale reviews from KevLehman and MartinSchoeler via 46bd4f0 October 17, 2022 13:14
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 19, 2022
@murtaza98
Copy link
Contributor Author

Hi @RocketChat/chat-engine Please need your help here for review? Thanks in advance 🙌

@murtaza98 murtaza98 added this to the 5.4.0 milestone Oct 19, 2022
@KevLehman KevLehman dismissed stale reviews from MartinSchoeler, cauefcr, and themself via 46270f1 November 3, 2022 19:01
KevLehman
KevLehman previously approved these changes Nov 3, 2022
View reviewed changes
sampaiodiego
sampaiodiego requested changes Nov 4, 2022
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you guys have done a good job on this one, good to see these changes moving forward.. I have just two small things to be considered 🤗

packages/rest-typings/src/v1/omnichannel.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/imports/server/rest/users.ts Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit ef93fac into develop Nov 7, 2022
@kodiakhq kodiakhq bot deleted the chore/migrate-saveInfo-1 branch November 7, 2022 20:14
MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022
@murtaza98 @KevLehman @MartinSchoeler
[NEW] Add new endpoint 'livechat/agent.status' & deprecate changeLive…
a00b3f7 
…chatStatus meteor method (#27047)

Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com>
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevLehman KevLehman KevLehman approved these changes

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@aleksandernsilva aleksandernsilva aleksandernsilva approved these changes

@MartinSchoeler MartinSchoeler Awaiting requested review from MartinSchoeler

@cauefcr cauefcr Awaiting requested review from cauefcr

Assignees
No one assigned
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@murtaza98 @aleksandernsilva @sampaiodiego @KevLehman @cauefcr @MartinSchoeler @ggazzo