Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Actionable messages are now sent to integrations webhook #27052

Merged
merged 8 commits into from
Oct 17, 2022

Conversation

cauefcr
Copy link
Contributor

@cauefcr cauefcr commented Oct 11, 2022

Proposed changes (including videos or screenshots)

Actionable messages, with buttons and similar, (saved as blocks internally) were not being sent to external integrations, so CRMs and the like had no visibility on what was the actionable message sent, this PR adds a yaml version of the actions, as well as a proper json object with the same data on the webhook output, so that our clients can have more visibility in their process

Issue(s)

Steps to test or reproduce

  • Enable external integrations
  • Create a webhook for such integration (a simple echo server works fine)
  • Send a message with actionable items (like whatsapp templates)
  • Note that the message above is readable on the webhook

Further comments

OC-170

@cauefcr cauefcr added this to the 5.3.0 milestone Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #27052 (977ab4d) into develop (ded6352) will increase coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27052      +/-   ##
===========================================
+ Coverage    40.22%   40.72%   +0.50%     
===========================================
  Files          827      802      -25     
  Lines        18241    17810     -431     
  Branches      2020     1961      -59     
===========================================
- Hits          7337     7253      -84     
+ Misses       10609    10257     -352     
- Partials       295      300       +5     
Flag Coverage Δ
e2e 40.72% <ø> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@cauefcr cauefcr marked this pull request as ready for review October 13, 2022 12:25
@cauefcr cauefcr requested a review from a team as a code owner October 13, 2022 12:25
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 17, 2022
@kodiakhq kodiakhq bot merged commit 127d118 into develop Oct 17, 2022
@kodiakhq kodiakhq bot deleted the fix/blocks-integration branch October 17, 2022 19:16
@ggazzo ggazzo mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants