[FIX] Always parse encrypted messages on client #27092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27092 +/- ##
===========================================
+ Coverage 41.00% 41.71% +0.70%
===========================================
Files 851 826 -25
Lines 18679 18233 -446
Branches 2049 1988 -61
===========================================
- Hits 7660 7605 -55
+ Misses 10730 10342 -388
+ Partials 289 286 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
approved these changes
Nov 8, 2022
dionisio-bot
bot
added
the
stat: ready to merge
bkrith
pushed a commit
to bkrith/Rocket.Chat
that referenced
this pull request
Nov 12, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
We should ignore the cached
mdfield for encrypted messages and should always parse the messages.TC-10