Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] File upload receiving whole file to apply limits #27105

Merged
merged 8 commits into from
Nov 7, 2022

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Oct 19, 2022

Proposed changes (including videos or screenshots)

Issue(s)

ARCH-56

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested review from a team as code owners October 19, 2022 20:13
@sampaiodiego sampaiodiego requested a review from a team as a code owner October 20, 2022 13:15
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #27105 (f10fc57) into develop (91844b2) will increase coverage by 0.79%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27105      +/-   ##
===========================================
+ Coverage    41.02%   41.82%   +0.79%     
===========================================
  Files          833      808      -25     
  Lines        18407    17962     -445     
  Branches      2047     1985      -62     
===========================================
- Hits          7552     7512      -40     
+ Misses       10568    10163     -405     
  Partials       287      287              
Flag Coverage Δ
e2e 41.82% <ø> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@cauefcr cauefcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working great on our omnichannel endpoints, no issues, rejects GB-sized files very fast, approving.

@ggazzo ggazzo merged commit c9ac4eb into develop Nov 7, 2022
@ggazzo ggazzo deleted the fix-upload-limit branch November 7, 2022 16:53
@sampaiodiego sampaiodiego added this to the 5.3.1 milestone Nov 8, 2022
ggazzo added a commit that referenced this pull request Nov 14, 2022
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: Gabriel Casals <83978645+casalsgh@users.noreply.github.com>
@ggazzo ggazzo mentioned this pull request Nov 14, 2022
MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: Gabriel Casals <83978645+casalsgh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants