[IMPROVE] VideoConf Miss Config Modal #27153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27153 +/- ##
===========================================
+ Coverage 40.34% 41.17% +0.82%
===========================================
Files 845 818 -27
Lines 18378 17928 -450
Branches 2052 1986 -66
===========================================
- Hits 7415 7381 -34
+ Misses 10679 10263 -416
Partials 284 284
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
previously approved these changes
Nov 4, 2022
debdutdeb
requested changes
Nov 4, 2022
apps/meteor/client/views/room/contextualBar/VideoConference/VideoConfConfigModal.tsx
Outdated
Show resolved
Hide resolved
ggazzo
approved these changes
Nov 10, 2022
debdutdeb
approved these changes
Nov 10, 2022
dionisio-bot
bot
added
stat: ready to merge
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Jira Issue: VC-9
Issue(s)
Steps to test or reproduce
Further comments