[IMPROVE] Add message name container component to message name header and system message #27184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipemarins
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #27184 +/- ##
===========================================
+ Coverage 41.03% 41.98% +0.95%
===========================================
Files 841 813 -28
Lines 18352 17840 -512
Branches 2054 1989 -65
===========================================
- Hits 7530 7491 -39
+ Misses 10535 10062 -473
Partials 287 287
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
previously approved these changes
Nov 9, 2022
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
approved these changes
Nov 21, 2022
ggazzo
approved these changes
Nov 22, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
… and system message (#27184)
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
… and system message (#27184)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Add
MessageNameContainerwrapper to displaynameandusernameinline and separate them with a blank space.Update font size of system message:
Before:
After:
Add removed message variation to
ThreadMessageOrigincomponentBefore:
After:
Issue(s)
Steps to test or reproduce
Further comments