Chore: Rewrite AutoCompleteDepartment to TypeScript #27198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27198 +/- ##
===========================================
+ Coverage 40.29% 41.15% +0.85%
===========================================
Files 848 819 -29
Lines 18443 17929 -514
Branches 2050 1986 -64
===========================================
- Hits 7432 7378 -54
+ Misses 10727 10266 -461
- Partials 284 285 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
changed the title
aleksandernsilva
requested changes
Nov 7, 2022
apps/meteor/ee/client/omnichannel/cannedResponses/components/cannedResponseForm.tsx
Outdated
Show resolved
Hide resolved
aleksandernsilva
requested changes
Nov 7, 2022
aleksandernsilva
previously approved these changes
Nov 8, 2022
KevLehman
reviewed
Nov 9, 2022
aleksandernsilva
previously approved these changes
Nov 9, 2022
dionisio-bot
bot
added
stat: ready to merge
aleksandernsilva
previously approved these changes
Nov 11, 2022
ggazzo
requested changes
Nov 11, 2022
apps/meteor/client/views/omnichannel/currentChats/FilterByText.tsx
Outdated
Show resolved
Hide resolved
ggazzo
approved these changes
Nov 12, 2022
aleksandernsilva
approved these changes
Nov 13, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 18, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Department field inside of current chats is one of the places who uses AutoCompleteDeparment:
Issue(s)
Steps to test or reproduce
Further comments
OC-420