Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Add searchTerm support for livechat/rid/messages API #27214

Merged
merged 3 commits into from
Nov 21, 2022

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Nov 8, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

OC-425

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #27214 (33d6f00) into develop (e2e465c) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27214      +/-   ##
===========================================
- Coverage    41.04%   40.88%   -0.17%     
===========================================
  Files          851      851              
  Lines        18678    18700      +22     
  Branches      2050     2050              
===========================================
- Hits          7666     7645      -21     
- Misses       10725    10769      +44     
+ Partials       287      286       -1     
Flag Coverage Δ
e2e 40.88% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review November 9, 2022 02:55
@KevLehman KevLehman requested review from a team as code owners November 9, 2022 02:55
@KevLehman KevLehman added this to the 5.4.0 milestone Nov 10, 2022
Copy link
Contributor

@cauefcr cauefcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 11, 2022
@ggazzo ggazzo merged commit eb1bd01 into develop Nov 21, 2022
@ggazzo ggazzo deleted the improve/search-messages-by-term-on-livechat-apis branch November 21, 2022 18:13
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants