-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] Add searchTerm support for livechat/rid/messages API #27214
Merged
ggazzo
merged 3 commits into
develop
from
improve/search-messages-by-term-on-livechat-apis
Nov 21, 2022
Merged
[IMPROVE] Add searchTerm support for livechat/rid/messages API #27214
ggazzo
merged 3 commits into
develop
from
improve/search-messages-by-term-on-livechat-apis
Nov 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27214 +/- ##
===========================================
- Coverage 41.04% 40.88% -0.17%
===========================================
Files 851 851
Lines 18678 18700 +22
Branches 2050 2050
===========================================
- Hits 7666 7645 -21
- Misses 10725 10769 +44
+ Partials 287 286 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
MartinSchoeler
previously requested changes
Nov 10, 2022
cauefcr
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
dionisio-bot
bot
added
the
stat: ready to merge
PR tested and approved waiting for merge
label
Nov 11, 2022
ggazzo
approved these changes
Nov 21, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
OC-425