Chore: Improve configurations related to Typescript in Livechat #27232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dionisio-bot
bot
added
the
stat: ready to merge
tassoevan
approved these changes
Nov 10, 2022
Codecov Report
@@ Coverage Diff @@
## develop #27232 +/- ##
===========================================
+ Coverage 41.01% 41.69% +0.68%
===========================================
Files 851 826 -25
Lines 18700 18255 -445
Branches 2050 1988 -62
===========================================
- Hits 7669 7611 -58
+ Misses 10745 10355 -390
- Partials 286 289 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
bkrith
pushed a commit
to bkrith/Rocket.Chat
that referenced
this pull request
Nov 12, 2022
MartinSchoeler
added a commit
that referenced
this pull request
Nov 18, 2022
MartinSchoeler
added a commit
that referenced
this pull request
Nov 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having issues using jsx files on the livechat package, due the way we are using preact + storybook.
This should fix the issue with the jsx files and allow us to proceed with the conversion of livechat to Typescript