Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Shrug missing backslash character #27233

Merged
merged 3 commits into from
Nov 10, 2022
Merged

[FIX] Shrug missing backslash character #27233

merged 3 commits into from
Nov 10, 2022

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Nov 10, 2022

Proposed changes (including videos or screenshots)

Previously the escape character \ was escaping everything.

To avoid unexpected text formatting errors it was restricted to only escape curtains chars like: * _ ~ ` # .
Doing so the Shrug had to change in the code to display the correct ASCII Art

Issue(s)

closes #26907
closes #26800

Steps to reproduce:

  1. Create a message using /shrug.

Expected behavior:

The kaomoji being rendered looks as follows: ¯\_(ツ)_/¯

Actual behavior:

The kaomoji is missing an arm: ¯_(ツ)_/¯

image

Further comments

The Shrug issue will be fixed after this Pull Request and RocketChat/fuselage#899 are released

TC-99

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@011a1a2). Click here to learn what that means.
The diff coverage is 0.00%.

❗ Current head fcc693c differs from pull request most recent head af9eaf4. Consider uploading reports for the commit af9eaf4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #27233   +/-   ##
==========================================
  Coverage           ?   41.75%           
==========================================
  Files              ?      826           
  Lines              ?    18255           
  Branches           ?     1988           
==========================================
  Hits               ?     7623           
  Misses             ?    10347           
  Partials           ?      285           
Flag Coverage Δ
e2e 41.75% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@gabriellsh gabriellsh marked this pull request as ready for review November 10, 2022 20:21
@gabriellsh gabriellsh requested a review from a team as a code owner November 10, 2022 20:21
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 10, 2022
@ggazzo ggazzo merged commit 9aec545 into develop Nov 10, 2022
@ggazzo ggazzo deleted the fix/shrug branch November 10, 2022 21:30
bkrith pushed a commit to bkrith/Rocket.Chat that referenced this pull request Nov 12, 2022
Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
MartinSchoeler pushed a commit that referenced this pull request Nov 18, 2022
Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022
Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backslashes in messages don't show without escaping /shrug gets an arm removed
3 participants