-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Shrug missing backslash character #27233
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #27233 +/- ##
==========================================
Coverage ? 41.75%
==========================================
Files ? 826
Lines ? 18255
Branches ? 1988
==========================================
Hits ? 7623
Misses ? 10347
Partials ? 285
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Proposed changes (including videos or screenshots)
Previously the escape character
\
was escaping everything.To avoid unexpected text formatting errors it was restricted to only escape curtains chars like: * _ ~ ` # .
Doing so the Shrug had to change in the code to display the correct ASCII Art
Issue(s)
closes #26907
closes #26800
Steps to reproduce:
/shrug
.Expected behavior:
The kaomoji being rendered looks as follows:
¯\_(ツ)_/¯
Actual behavior:
The kaomoji is missing an arm:
¯_(ツ)_/¯
Further comments
The Shrug issue will be fixed after this Pull Request and RocketChat/fuselage#899 are released
TC-99