Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Upgrading fuselage package and fix quote message prepend #27307

Merged
merged 7 commits into from
Nov 22, 2022

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Nov 21, 2022

Proposed changes (including videos or screenshots)

Adding heading styles to message

[OLD] As it was before this change:

image

[NEW] As it is NOW:

image


Fix heading style in quote messages

Before:
Screen Shot 2022-11-22 at 14 41 55

After:
Screen Shot 2022-11-22 at 14 41 47

Issue(s)

RocketChat/fuselage#904

Steps to test or reproduce

Further comments

TC-273

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #27307 (31e9467) into develop (26967a2) will increase coverage by 0.33%.
The diff coverage is 15.38%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27307      +/-   ##
===========================================
+ Coverage    41.17%   41.50%   +0.33%     
===========================================
  Files          841      838       -3     
  Lines        18354    18215     -139     
  Branches      2055     2055              
===========================================
+ Hits          7557     7560       +3     
+ Misses       10509    10366     -143     
- Partials       288      289       +1     
Flag Coverage Δ
e2e 41.50% <15.38%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev marked this pull request as draft November 21, 2022 18:04
@hugocostadev hugocostadev changed the title [FIX] Upgrading message-parser package to add new feature [FIX] Upgrading fuselage package and fix quote message prepend Nov 22, 2022
@guijun13 guijun13 marked this pull request as ready for review November 22, 2022 17:36
@guijun13 guijun13 requested a review from a team as a code owner November 22, 2022 17:36
@hugocostadev hugocostadev added this to the 5.4.0 milestone Nov 22, 2022
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 22, 2022
@ggazzo ggazzo merged commit d218cf6 into develop Nov 22, 2022
@ggazzo ggazzo deleted the add/heading-parser branch November 22, 2022 19:21
MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022
Co-authored-by: Guilherme Jun Grillo <48109548+guijun13@users.noreply.github.com>
MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022
Co-authored-by: Guilherme Jun Grillo <48109548+guijun13@users.noreply.github.com>
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants