Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Threads replied message not clickable on new message template #27359

Merged
merged 4 commits into from
Dec 2, 2022

Conversation

filipemarins
Copy link
Contributor

@filipemarins filipemarins commented Nov 25, 2022

Proposed changes (including videos or screenshots)

Add the link to the parent message on the ThreadMessagePreview component;
Add message ignored status to the parent message too;
Also, allow clicking the message when is ignored status.

Issue(s)

Steps to test or reproduce

Further comments

Bump fuselage to get the cursor pointer on hover status.

Fixes #27207

@filipemarins filipemarins marked this pull request as ready for review November 25, 2022 16:09
@filipemarins filipemarins requested a review from a team as a code owner November 25, 2022 16:09
@ggazzo
Copy link
Member

ggazzo commented Nov 25, 2022

there is nothing wrong the parser this template/react related

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #27359 (6ab0c70) into develop (c98c719) will increase coverage by 0.99%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27359      +/-   ##
===========================================
+ Coverage    41.31%   42.31%   +0.99%     
===========================================
  Files          839      812      -27     
  Lines        18269    17750     -519     
  Branches      2085     2010      -75     
===========================================
- Hits          7548     7511      -37     
+ Misses       10432     9950     -482     
  Partials       289      289              
Flag Coverage Δ
e2e 42.31% <ø> (+0.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@filipemarins filipemarins changed the title [FIX] Threads replied message not clickable on New Message Parser [FIX] Threads replied message not clickable on new message Template Nov 25, 2022
@filipemarins filipemarins changed the title [FIX] Threads replied message not clickable on new message Template [FIX] Threads replied message not clickable on new message template Nov 25, 2022
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 2, 2022
@kodiakhq kodiakhq bot merged commit e3295d4 into develop Dec 2, 2022
@kodiakhq kodiakhq bot deleted the tc-260 branch December 2, 2022 18:18
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
@alvaropmello alvaropmello added this to the 5.4.0 milestone Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to Original Post doesn't work on 5.x Message Template
5 participants