Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Livechat: Allow resolving external image and media blocks #27387

Merged
merged 9 commits into from
Dec 2, 2022

Conversation

cauefcr
Copy link
Contributor

@cauefcr cauefcr commented Nov 28, 2022

OC-198

Proposed changes (including videos or screenshots)

Allow external urls to be viewed on livechat.

Issue(s)

issue#26511

Steps to test or reproduce

paste the below message on a chat, and check if the image appears

![if you can read this on rocket.chat the bug still exists](https://assets.digitalocean.com/articles/alligator/boo.svg)

Further comments

Fixes botpress integration issue

Fixes #26511

@cauefcr cauefcr changed the title [IMPROVE] Livechat: Allow external attachments to be resolved [CHORE] Livechat: Allow external attachments to be resolved Nov 28, 2022
@cauefcr cauefcr changed the title [CHORE] Livechat: Allow external attachments to be resolved [CHORE] Livechat: Allow resolving external attachments Nov 28, 2022
@cauefcr cauefcr changed the title [CHORE] Livechat: Allow resolving external attachments [IMPROVE] Livechat: Allow resolving external attachments Nov 28, 2022
@cauefcr cauefcr changed the title [IMPROVE] Livechat: Allow resolving external attachments [IMPROVE] Livechat: Allow resolving external image and media blocks Nov 28, 2022
@cauefcr cauefcr marked this pull request as ready for review November 28, 2022 20:38
@cauefcr cauefcr requested review from a team as code owners November 28, 2022 20:38
@cauefcr cauefcr changed the title [IMPROVE] Livechat: Allow resolving external image and media blocks [FIX] Livechat: Allow resolving external image and media blocks Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #27387 (5944a30) into develop (c98c719) will increase coverage by 0.92%.
The diff coverage is n/a.

❗ Current head 5944a30 differs from pull request most recent head 6c19e0b. Consider uploading reports for the commit 6c19e0b to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27387      +/-   ##
===========================================
+ Coverage    41.31%   42.23%   +0.92%     
===========================================
  Files          839      812      -27     
  Lines        18269    17736     -533     
  Branches      2085     1990      -95     
===========================================
- Hits          7548     7491      -57     
+ Misses       10432     9957     -475     
+ Partials       289      288       -1     
Flag Coverage Δ
e2e 42.23% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added this to the 5.5.0 milestone Nov 30, 2022
@KevLehman
Copy link
Contributor

@MartinSchoeler can you help us with the FE review?
@cauefcr , did you create the task for doing the UI tests for this PR as a separate operation? 👀

@cauefcr
Copy link
Contributor Author

cauefcr commented Dec 1, 2022

@cauefcr , did you create the task for doing the UI tests for this PR as a separate operation?

No, I had a UI test working before, but the markdown stopped being parsed, the only way to test this is with an app, which QA already has in their hands, so this PR has no tests.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 2, 2022
@ggazzo ggazzo merged commit 07ea6d1 into develop Dec 2, 2022
@ggazzo ggazzo deleted the omni/resolve-external-attachments branch December 2, 2022 12:59
KevLehman pushed a commit that referenced this pull request Dec 2, 2022
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
@alvaropmello alvaropmello modified the milestones: 5.5.0, 6.0.0-prep Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LiveChat-Widget adds an extra URL prefix when sending image URL
7 participants