-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Livechat: Allow resolving external image and media blocks #27387
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #27387 +/- ##
===========================================
+ Coverage 41.31% 42.23% +0.92%
===========================================
Files 839 812 -27
Lines 18269 17736 -533
Branches 2085 1990 -95
===========================================
- Hits 7548 7491 -57
+ Misses 10432 9957 -475
+ Partials 289 288 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
@MartinSchoeler can you help us with the FE review? |
No, I had a UI test working before, but the markdown stopped being parsed, the only way to test this is with an app, which QA already has in their hands, so this PR has no tests. |
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
OC-198
Proposed changes (including videos or screenshots)
Allow external urls to be viewed on livechat.
Issue(s)
issue#26511
Steps to test or reproduce
paste the below message on a chat, and check if the image appears
Further comments
Fixes botpress integration issue
Fixes #26511