-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Fix issues with ContactHistoryItem #27406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27406 +/- ##
===========================================
+ Coverage 41.09% 42.06% +0.96%
===========================================
Files 839 812 -27
Lines 18255 17736 -519
Branches 2065 1990 -75
===========================================
- Hits 7502 7460 -42
+ Misses 10463 9988 -475
+ Partials 290 288 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
tiagoevanp
requested changes
Nov 29, 2022
apps/meteor/client/views/omnichannel/contactHistory/ContactHistoryItem.tsx
Outdated
Show resolved
Hide resolved
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Nov 30, 2022
ggazzo
previously requested changes
Nov 30, 2022
apps/meteor/client/views/omnichannel/contactHistory/ContactHistoryItem.tsx
Outdated
Show resolved
Hide resolved
tiagoevanp
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes:
I've also changed the layout a bit, to better mirror the future design for this part of the UI
OC-448
OC-449