Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Fix issues with ContactHistoryItem #27406

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Conversation

MartinSchoeler
Copy link
Contributor

This fixes:

  • Empty closed message issue
  • Missing Dates on contact history item

I've also changed the layout a bit, to better mirror the future design for this part of the UI

Screen Shot 2022-11-29 at 2 24 28 PM

OC-448
OC-449

@MartinSchoeler MartinSchoeler requested a review from a team as a code owner November 29, 2022 17:30
@MartinSchoeler MartinSchoeler added this to the 5.4.0 milestone Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #27406 (bd8cb3a) into develop (ab6da16) will increase coverage by 0.96%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27406      +/-   ##
===========================================
+ Coverage    41.09%   42.06%   +0.96%     
===========================================
  Files          839      812      -27     
  Lines        18255    17736     -519     
  Branches      2065     1990      -75     
===========================================
- Hits          7502     7460      -42     
+ Misses       10463     9988     -475     
+ Partials       290      288       -2     
Flag Coverage Δ
e2e 42.06% <ø> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 30, 2022
@kodiakhq kodiakhq bot merged commit f3ddd12 into develop Nov 30, 2022
@kodiakhq kodiakhq bot deleted the chat-hist-reg branch November 30, 2022 14:58
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants