Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: bumping apps engine version #27414

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Conversation

AllanPazRibeiro
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@AllanPazRibeiro AllanPazRibeiro changed the title chore: bumping apps engine version Chore: bumping apps engine version Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #27414 (bb26d64) into develop (c58567c) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27414      +/-   ##
===========================================
+ Coverage    42.09%   42.12%   +0.03%     
===========================================
  Files          812      812              
  Lines        17750    17750              
  Branches      2010     2010              
===========================================
+ Hits          7471     7478       +7     
+ Misses        9987     9983       -4     
+ Partials       292      289       -3     
Flag Coverage Δ
e2e 42.12% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert added this to the 5.4.0 milestone Nov 30, 2022
@d-gubert d-gubert requested a review from a team November 30, 2022 15:58
d-gubert
d-gubert previously approved these changes Nov 30, 2022
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is that correct? there is no changes on yarn.lock and I think at this time we should be removing the alpha tag 🤔

@ggazzo ggazzo merged commit de47a4d into develop Dec 2, 2022
@ggazzo ggazzo deleted the bump/bump-apps-engine-version branch December 2, 2022 12:58
KevLehman pushed a commit that referenced this pull request Dec 2, 2022
Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants