Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: fix small issues before release #27443

Merged
merged 3 commits into from
Dec 3, 2022
Merged

Regression: fix small issues before release #27443

merged 3 commits into from
Dec 3, 2022

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Dec 3, 2022

is_uploading missing translations
register username form bug
login form error not reseting properly

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo requested review from a team as code owners December 3, 2022 18:30
@ggazzo ggazzo merged commit aabb324 into develop Dec 3, 2022
@ggazzo ggazzo deleted the regression/last branch December 3, 2022 21:31
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
@casalsgh casalsgh added this to the 5.4.1 milestone Dec 15, 2022
@ggazzo
Copy link
Member Author

ggazzo commented Dec 15, 2022

there's no way this pull request could be marked for 5.4.1 because it was released in the release candidate, precisely to allow us to make the release without any known bugs

@ggazzo ggazzo removed this from the 5.4.1 milestone Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants