Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Restrict ChatMessages API - Phase 2 #27457

Merged
merged 21 commits into from
Dec 5, 2022

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

It split ChatMessages service class into a collection of smaller objects, in a composition pattern fashion. Additionally, it loosens its dependency on the DOM tree and assumes almost all methods are asynchronous.

Issue(s)

Replaces #27283

Steps to test or reproduce

Further comments

  • The naming convention is a little wanky; it might change.
  • Initially this API was redesigned as "reactivity friendly" -- i.e. queries over state should have a pair of functions get and subscribe -- but the effort in refactoring some complex mutations took place in the schedule. The next phase might address this issue.
  • The flows are the most dependent and complex behaviors. A flow might depend on another flow, trigger UI effects, and handle exceptions by themselves.

@ggazzo ggazzo marked this pull request as ready for review December 5, 2022 17:29
@ggazzo ggazzo requested review from a team as code owners December 5, 2022 17:29
@ggazzo ggazzo merged commit 6163275 into develop Dec 5, 2022
@ggazzo ggazzo deleted the refactor/restrict-chat-messages-api branch December 5, 2022 18:22
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants