[FIX] OmnichannelRoomIconProvider order breaking VideoConfPopup #27740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27740 +/- ##
===========================================
+ Coverage 41.32% 42.27% +0.94%
===========================================
Files 841 814 -27
Lines 17706 17189 -517
Branches 1996 1921 -75
===========================================
- Hits 7317 7266 -51
+ Misses 10152 9683 -469
- Partials 237 240 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
approved these changes
Jan 20, 2023
aleksandernsilva
approved these changes
Jan 20, 2023
ggazzo
changed the title
sampaiodiego
pushed a commit
that referenced
this pull request
Jan 24, 2023
Merged
sampaiodiego
pushed a commit
that referenced
this pull request
Jan 25, 2023
gabriellsh
added a commit
that referenced
this pull request
Jan 30, 2023
…etChat/Rocket.Chat into matrixSearch * 'feat/federation-search-public-rooms' of github.com:RocketChat/Rocket.Chat: fix: prevent to the user join the room twice Chore: OmnichannelRoomIconProvider order breaking VideoConfPopup (#27740) [FIX] Toast notification ignoring 403 errors (#27624) [FIX] Not all messages in chat conversations are available when forwarding between agents or departments. (#27816) [IMPROVE] Emoji picker for large amount of custom emojis (#27745)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Jira Issue VC-39
Issue(s)
Steps to test or reproduce
Further comments