Chore: Remove OS version for device management #27786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27786 +/- ##
===========================================
+ Coverage 41.95% 42.99% +1.04%
===========================================
Files 847 820 -27
Lines 17758 17241 -517
Branches 2020 1945 -75
===========================================
- Hits 7450 7413 -37
+ Misses 10041 9562 -479
+ Partials 267 266 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
hugocostadev
previously approved these changes
Jan 19, 2023
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
hugocostadev
approved these changes
Jan 25, 2023
dionisio-bot
bot
added
the
stat: ready to merge
|
This PR could not be merged because the GitHub API returned an internal server error. To enable Kodiak on this pull request please remove the When the GitHub API returns an internal server error (HTTP status code 500), it is not safe for Kodiak to retry merging. For more information please see https://kodiakhq.com/docs/troubleshooting#merge-errors If you need help, you can open a GitHub issue, check the docs, or reach us privately at support@kodiakhq.com. |
gabriellsh
added a commit
that referenced
this pull request
Feb 6, 2023
….Chat into matrixSearch * 'feat/federation-feat-2' of github.com:RocketChat/Rocket.Chat: (31 commits) fix: removing file wrongly merged on update merge [NEW] Federation search public rooms in the Matrix network (#27434) Chore: Refactor other kinds of message - Phase 2 (#27927) Chore: improve some e2e selectors (#27936) [NEW] Warning Popup reinforcing Zapier deprecation on Integrations Admin settings (#27744) Chore: Notify Marketplace on App Install (#27925) i18n: Language update from LingoHub 🤖 on 2023-01-23Z (#27814) [FIX][ENTERPRISE] DDP streamer sending data to destroyed streams (#27929) Chore: Migrate cached collections to TypeScript (#27909) i18n: Language update from LingoHub 🤖 on 2023-01-09Z (#27705) [FIX] Reduce re-subscription on `notify-room/user-activity` stream event (#27911) [FIX] Unread Message count not displayed for new messages in Omni-Rooms (#27539) Chore: Improve service's licence check (#27872) [IMPROVE] Livechat Persian translation (#27825) Chore(deps): Bump thehanimo/pr-title-checker from 1.3.4 to 1.3.6 (#27884) Chore: use useQuery in place of deprecated useEndpointData (#27673) Chore: Update Some Composer Icons (#27862) Regression: Undefined default message context (#27870) Chore: Remove OS version for device management (#27786) [BREAK] Remove less theming (#27647) ...
Merged
Kishn0109
pushed a commit
to Kishn0109/Rocket.Chat
that referenced
this pull request
May 26, 2023
Kishn0109
pushed a commit
to Kishn0109/Rocket.Chat
that referenced
this pull request
May 26, 2023
Co-authored-by: Hugo Costa <hugocarreiracosta@gmail.com>
janainaCoelhoRocketchat
pushed a commit
that referenced
this pull request
Aug 18, 2023
janainaCoelhoRocketchat
pushed a commit
that referenced
this pull request
Aug 18, 2023
Co-authored-by: Hugo Costa <hugocarreiracosta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR removes the OS version from the device management page, this is because the
user-agentis returning the wrong version.Issue(s)
Steps to test or reproduce
Further comments
TC-166