[FIX] Emoji rendering on reactions #27863
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The issue is when using a CDN, the
CDN_PREFIX
setting value can be a full domain (i.e.:https://my-cdn.rocket.chat
), which will make thesplit(':')
do unintentional splits, causing the issue.I changed to just use
emojiElement.style.backgroundImage
in case it is available but kept the old way to get thebackgroundImage
just in case.Issue(s)
Steps to test or reproduce
Further comments