Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Emoji rendering on reactions #27863

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

The issue is when using a CDN, the CDN_PREFIX setting value can be a full domain (i.e.: https://my-cdn.rocket.chat), which will make the split(':') do unintentional splits, causing the issue.

I changed to just use emojiElement.style.backgroundImage in case it is available but kept the old way to get the backgroundImage just in case.

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team as a code owner January 26, 2023 22:03
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #27863 (e96cb9d) into develop (7ecedc4) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27863      +/-   ##
===========================================
+ Coverage    43.18%   43.20%   +0.02%     
===========================================
  Files          818      818              
  Lines        17147    17148       +1     
  Branches      1945     1946       +1     
===========================================
+ Hits          7405     7409       +4     
+ Misses        9475     9473       -2     
+ Partials       267      266       -1     
Flag Coverage Δ
e2e 43.20% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 973a1d9 into develop Jan 26, 2023
@kodiakhq kodiakhq bot deleted the fix-reaction-emoji-rendering branch January 26, 2023 23:28
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants