Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Fix improper usage of useEndpointData #28050

Merged
merged 11 commits into from
Feb 24, 2023
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { Tabs } from '@rocket.chat/fuselage';
import { useCurrentRoute, useRoute, useRouteParameter, usePermission, useTranslation } from '@rocket.chat/ui-contexts';
import type { ReactElement } from 'react';
import React, { useEffect, useCallback, useState } from 'react';
import React, { useEffect, useCallback } from 'react';

import Page from '../../../components/Page';
import { queryClient } from '../../../lib/queryClient';
import NotAuthorizedPage from '../../notAuthorized/NotAuthorizedPage';
import ContextualBar from './ContextualBar';
import CallTab from './calls/CallTab';
Expand All @@ -30,7 +31,7 @@ const OmnichannelDirectoryPage = (): ReactElement => {

const handleTabClick = useCallback((tab) => (): void => directoryRoute.push({ tab }), [directoryRoute]);

const [chatReload, setChatReload] = useState();
const chatReload = () => queryClient.invalidateQueries({ queryKey: ['current-chats'] });
KevLehman marked this conversation as resolved.
Show resolved Hide resolved

const t = useTranslation();

Expand All @@ -54,9 +55,7 @@ const OmnichannelDirectoryPage = (): ReactElement => {
</Tabs.Item>
</Tabs>
<Page.Content>
{(tab === 'contacts' && <ContactTab />) ||
(tab === 'chats' && <ChatTab setChatReload={setChatReload} />) ||
(tab === 'calls' && <CallTab />)}
{(tab === 'contacts' && <ContactTab />) || (tab === 'chats' && <ChatTab />) || (tab === 'calls' && <CallTab />)}
</Page.Content>
</Page>
<ContextualBar chatReload={chatReload} />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
import { usePermission } from '@rocket.chat/ui-contexts';
import type { ReactElement, SetStateAction, Dispatch } from 'react';
import type { ReactElement } from 'react';
import React from 'react';

import NotAuthorizedPage from '../../../notAuthorized/NotAuthorizedPage';
import ChatTable from './ChatTable';

// TODO Check if I need to type the setstateaction params, if I should do:
// { setChatReload: Dispatch<SetStateAction<(param: () => void) => void>> }
const ChatTab = (props: { setChatReload: Dispatch<SetStateAction<any>> }): ReactElement => {
const ChatTab = (): ReactElement => {
const hasAccess = usePermission('view-l-room');

if (hasAccess) {
return <ChatTable {...props} />;
return <ChatTable />;
}

return <NotAuthorizedPage />;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ import { useDebouncedValue, useMutableCallback } from '@rocket.chat/fuselage-hoo
import { useRoute, useTranslation } from '@rocket.chat/ui-contexts';
import { Meteor } from 'meteor/meteor';
import moment from 'moment';
import type { FC, ReactElement, Dispatch, SetStateAction } from 'react';
import React, { useState, useMemo, useCallback, useEffect } from 'react';
import type { FC, ReactElement } from 'react';
import React, { useState, useMemo, useCallback } from 'react';

import FilterByText from '../../../../components/FilterByText';
import GenericTable from '../../../../components/GenericTable';
import { useEndpointData } from '../../../../hooks/useEndpointData';
import GenericTable, { GenericTableLoadingTable } from '../../../../components/GenericTable';
import { useCurrentChats } from '../../currentChats/hooks/useCurrentChats';

const useQuery = (
{
Expand Down Expand Up @@ -42,7 +42,7 @@ const useQuery = (
[column, current, direction, itemsPerPage, userIdLoggedIn, text],
);

const ChatTable: FC<{ setChatReload: Dispatch<SetStateAction<any>> }> = ({ setChatReload }) => {
const ChatTable: FC = () => {
const [params, setParams] = useState<{ text?: string; current: number; itemsPerPage: 25 | 50 | 100 }>({
text: '',
current: 0,
Expand Down Expand Up @@ -74,12 +74,6 @@ const ChatTable: FC<{ setChatReload: Dispatch<SetStateAction<any>> }> = ({ setCh
}),
);

const { value: data, reload } = useEndpointData('/v1/livechat/rooms', query as any); // TODO: Check the typing for the livechat/rooms endpoint as it seems wrong

useEffect(() => {
setChatReload?.(() => reload);
}, [reload, setChatReload]);

const header = useMemo(
() =>
[
Expand Down Expand Up @@ -167,12 +161,21 @@ const ChatTable: FC<{ setChatReload: Dispatch<SetStateAction<any>> }> = ({ setCh
[onRowClick],
);

const result = useCurrentChats(query);

if (result.isLoading) {
return <GenericTableLoadingTable headerCells={6} />;
}
if (result.error) {
return <Box mbs='x16'>{t('Something_went_wrong')}</Box>;
}

return (
<GenericTable
header={header}
renderRow={renderRow}
results={data?.rooms}
total={data?.total}
results={result.data?.rooms}
total={result.data?.total}
setParams={setParams}
params={params}
renderFilter={({ onChange, ...props }: any): ReactElement => <FilterByText onChange={onChange} {...props} />}
Expand Down