Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Add Eslint rules to tests #28074

Merged
merged 8 commits into from
Feb 17, 2023
Merged

Chore: Add Eslint rules to tests #28074

merged 8 commits into from
Feb 17, 2023

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 16, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo changed the base branch from develop to fix-tests-not-working February 16, 2023 16:50
ggazzo
ggazzo commented Feb 16, 2023
View reviewed changes
apps/meteor/package.json Outdated Show resolved Hide resolved
Base automatically changed from fix-tests-not-working to develop February 16, 2023 18:24
@codecov
Copy link

codecov bot commented Feb 16, 2023 •
edited
Loading

Codecov Report

Merging #28074 (3de8117) into develop (5a184a4) will decrease coverage by 1.84%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28074      +/-   ##
===========================================
- Coverage    43.87%   42.03%   -1.84%     
===========================================
  Files          791      768      -23     
  Lines        15392    14969     -423     
  Branches      2131     2125       -6     
===========================================
- Hits          6753     6292     -461     
- Misses        8352     8406      +54     
+ Partials       287      271      -16
Flag Coverage Δ
e2e 41.99% <ø> (-1.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review February 16, 2023 20:13
@ggazzo ggazzo requested a review from a team as a code owner February 16, 2023 20:13
tassoevan
tassoevan requested changes Feb 16, 2023
View reviewed changes
apps/meteor/package.json Outdated Show resolved Hide resolved
tassoevan
tassoevan previously approved these changes Feb 16, 2023
View reviewed changes
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 16, 2023
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Feb 16, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Feb 16, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Feb 17, 2023
@ggazzo ggazzo merged commit 074cafd into develop Feb 17, 2023
@ggazzo ggazzo deleted the chore/ci-perf branch February 17, 2023 05:58
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan left review comments

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggazzo @tassoevan