fix: Added check if count is truthy on cleanRoomHistory

[LucianoPierdona]

Proposed changes (including videos or screenshots)

This PR adds a check when the room is updated inside the function removeByIdPinnedTimestampLimitAndUsers which is called on cleanRoomHistory; It has been added because even when the room wasn't being updated, the _updatedAt was changed, and caused move chats to the top of the list even when nothing has changed there.

Issue(s)

#27956

Steps to test or reproduce

• Enable Retention Policy.
• For clarity, set "Use Advanced Retention Policy Cron" to every 5 minutes
  */5 * * * *
• After 5 minutes, query the database to verify that the _updatedAt value has changed in each room:
  db.rocketchat_room.find({ }, {"_updatedAt": 1 }).pretty()

Further comments

TC-488

[codecov]

Codecov Report

Merging #28081 (3733d6b) into develop (c75272b) will decrease coverage by 5.89%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #28081      +/-   ##
===========================================
- Coverage    46.86%   40.98%   -5.89%     
===========================================
  Files          707      688      -19     
  Lines        13241    13022     -219     
  Branches      2221     2182      -39     
===========================================
- Hits          6206     5337     -869     
- Misses        6720     7398     +678     
+ Partials       315      287      -28     

Flag	Coverage Δ
e2e	40.96% <ø> (-5.88%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[sampaiodiego]

while I don't have to time this properly, what do you think about creating some tests?

it doesn't need to use the scheduled "history clean" that you need to wait some minutes for it to run, you can trigger the "history clean" manually and assert the room data has not changed.

[LucianoPierdona]

@sampaiodiego sure, I can do that

[changeset-bot]

🦋 Changeset detected

Latest commit: 3733d6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/api-client	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/models	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR