Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: improve global setup e2e #28087

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Chore: improve global setup e2e #28087

merged 4 commits into from
Feb 17, 2023

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 17, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo requested a review from a team as a code owner February 17, 2023 05:27
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #28087 (5d3b9b7) into develop (29d369a) will decrease coverage by 4.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28087      +/-   ##
===========================================
- Coverage    43.73%   39.58%   -4.16%     
===========================================
  Files          791      745      -46     
  Lines        15397    14681     -716     
  Branches      2132     2029     -103     
===========================================
- Hits          6734     5811     -923     
- Misses        8373     8600     +227     
+ Partials       290      270      -20     
Flag Coverage Δ
e2e 39.55% <ø> (-4.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get why the changes.. but they're harmless, so =)

@ggazzo ggazzo merged commit e6ffdb3 into develop Feb 17, 2023
@ggazzo ggazzo deleted the chore/improve-global-setup branch February 17, 2023 13:53
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants