-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Playwright test improvements #28100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
force-pushed
the
improve/playwrigt-sessions
branch
2 times, most recently
from
February 18, 2023 15:49
ab3f660
to
d85b15a
Compare
rodrigok
force-pushed
the
improve/playwrigt-sessions
branch
from
February 18, 2023 16:02
d85b15a
to
ea6a30f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #28100 +/- ##
===========================================
- Coverage 44.88% 44.83% -0.06%
===========================================
Files 766 766
Lines 14893 14894 +1
Branches 2067 2068 +1
===========================================
- Hits 6684 6677 -7
- Misses 7918 7925 +7
- Partials 291 292 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
rodrigok
force-pushed
the
improve/playwrigt-sessions
branch
from
February 20, 2023 14:18
29ba679
to
4ac16d6
Compare
KevLehman
reviewed
Feb 21, 2023
ggazzo
approved these changes
Feb 22, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes aims to simplify the creation of users for the tests and the usage of those users and sessions.
It replaces the file sessions by a global map of preexistent users containing the same information that were saved on files.
It replaces the initial login flow (via UI, which was slowing down the test startup) by a pre seed of those users and sessions containing a tokens generated based on the users's usernames.
It was necessary to make a small change on e2e tests to handle the logout, which was removing the session token from the database and to handle the encryption key persistence between tests.
It improves the DRY goal on omnichannel tests making the function to create context a generic one.
It improve the typing of the ILoginToken and adapt the necessary places.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments