Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Re-add app signature migration to fix the faulty previous one #28107

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

d-gubert
Copy link
Member

Proposed changes (including videos or screenshots)

Previously merged migration files ended up in a faulty migration

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #28107 (874cf81) into develop (4b2581d) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28107      +/-   ##
===========================================
+ Coverage    44.88%   44.90%   +0.02%     
===========================================
  Files          766      766              
  Lines        14893    14893              
  Branches      2067     2067              
===========================================
+ Hits          6684     6687       +3     
+ Misses        7918     7915       -3     
  Partials       291      291              
Flag Coverage Δ
e2e 44.86% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert added this to the 6.0.0 milestone Feb 20, 2023
@sampaiodiego
Copy link
Member

I might be missing something, but the code in both migration seems to be the same, so why would the new one not have the same result?

@sampaiodiego sampaiodiego merged commit ec99e15 into develop Feb 22, 2023
@sampaiodiego sampaiodiego deleted the regression/app-signature-migration branch February 22, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants