Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Gracefully stop DDP Streamer publication and close WS #28121

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

The old code was causing wrong counts on metrics of connected users while also keeping the "subscription" alive, keeping it on the subscription Set, causing this code to be executed on every message.

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego added this to the 6.0.0 milestone Feb 22, 2023
@sampaiodiego sampaiodiego requested a review from a team February 22, 2023 19:27
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #28121 (69b6ae0) into develop (b2b8665) will decrease coverage by 6.61%.
The diff coverage is 42.85%.

❗ Current head 69b6ae0 differs from pull request most recent head 6290d87. Consider uploading reports for the commit 6290d87 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28121      +/-   ##
===========================================
- Coverage    44.97%   38.36%   -6.61%     
===========================================
  Files          766      676      -90     
  Lines        14894    13279    -1615     
  Branches      2068     1899     -169     
===========================================
- Hits          6699     5095    -1604     
- Misses        7905     7936      +31     
+ Partials       290      248      -42     
Flag Coverage Δ
e2e 38.36% <42.85%> (-6.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego merged commit d74b32e into develop Feb 22, 2023
@sampaiodiego sampaiodiego deleted the fix-ddp-streamer-not-closing-pubs branch February 22, 2023 20:31
@sampaiodiego sampaiodiego modified the milestones: 6.0.0, 5.4.5 Mar 16, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants